Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(next-swc): Fix span for invalid 'use server' directives #62259

Merged
merged 2 commits into from
Feb 22, 2024
Merged

fix(next-swc): Fix span for invalid 'use server' directives #62259

merged 2 commits into from
Feb 22, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 20, 2024

What?

Highlight only 'use server', instead of the whole function body.

Why?

Other statements of the body is not related to the error.

How?

x-ref: https://vercel.slack.com/archives/C04CAN8CGCE/p1708353068632249?thread_ts=1708351927.544179&cid=C04CAN8CGCE

Closes PACK-2538

@kdy1 kdy1 self-assigned this Feb 20, 2024
@kdy1 kdy1 requested review from timneutkens, ijjk, shuding, huozhi and a team as code owners February 20, 2024 01:23
@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the Turbopack team. type: next labels Feb 20, 2024
@kdy1 kdy1 marked this pull request as draft February 20, 2024 01:25
@kdy1 kdy1 mentioned this pull request Feb 20, 2024
Merged
@ijjk
Copy link
Member

ijjk commented Feb 20, 2024 •
edited
Loading

Tests Passed

@ijjk
Copy link
Member

ijjk commented Feb 20, 2024 •
edited
Loading

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js kdy1/pack-2538 Change
buildDuration 14.2s 14.2s N/A
buildDurationCached 7.5s 7.7s ⚠️ +134ms
nodeModulesSize 197 MB 197 MB ✓
nextStartRea..uration (ms) 432ms 429ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/pack-2538 Change
1068-HASH.js gzip 30.3 kB 30.3 kB N/A
3f784ff6-HASH.js gzip 53.5 kB 53.5 kB N/A
4944-HASH.js gzip 5.04 kB 5.03 kB N/A
8423.HASH.js gzip 181 B 181 B ✓
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 32.1 kB 32.1 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB ✓
Overall change 47.1 kB 47.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/pack-2538 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js kdy1/pack-2538 Change
_app-HASH.js gzip 196 B 196 B ✓
_error-HASH.js gzip 184 B 183 B N/A
amp-HASH.js gzip 503 B 504 B N/A
css-HASH.js gzip 323 B 324 B N/A
dynamic-HASH.js gzip 2.5 kB 2.51 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 353 B 351 B N/A
hooks-HASH.js gzip 370 B 370 B ✓
image-HASH.js gzip 4.21 kB 4.2 kB N/A
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.68 kB 2.67 kB N/A
routerDirect..HASH.js gzip 313 B 314 B N/A
script-HASH.js gzip 386 B 385 B N/A
withRouter-HASH.js gzip 309 B 311 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 931 B 931 B ✓
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/pack-2538 Change
_buildManifest.js gzip 485 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/pack-2538 Change
index.html gzip 528 B 526 B N/A
link.html gzip 540 B 540 B ✓
withRouter.html gzip 523 B 522 B N/A
Overall change 540 B 540 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/pack-2538 Change
edge-ssr.js gzip 2.29 kB 2.29 kB N/A
page.js gzip 2.98 kB 2.98 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js kdy1/pack-2538 Change
middleware-b..fest.js gzip 624 B 626 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 466 B 465 B N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 990 B 990 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/pack-2538 Change
app-page-exp...dev.js gzip 166 kB 166 kB ✓
app-page-exp..prod.js gzip 95.9 kB 95.9 kB ✓
app-page-tur..prod.js gzip 97.6 kB 97.6 kB ✓
app-page-tur..prod.js gzip 92 kB 92 kB ✓
app-page.run...dev.js gzip 136 kB 136 kB ✓
app-page.run..prod.js gzip 90.6 kB 90.6 kB ✓
app-route-ex...dev.js gzip 22 kB 22 kB ✓
app-route-ex..prod.js gzip 14.9 kB 14.9 kB ✓
app-route-tu..prod.js gzip 14.9 kB 14.9 kB ✓
app-route-tu..prod.js gzip 14.6 kB 14.6 kB ✓
app-route.ru...dev.js gzip 21.7 kB 21.7 kB ✓
app-route.ru..prod.js gzip 14.6 kB 14.6 kB ✓
pages-api-tu..prod.js gzip 9.47 kB 9.47 kB ✓
pages-api.ru...dev.js gzip 9.74 kB 9.74 kB ✓
pages-api.ru..prod.js gzip 9.47 kB 9.47 kB ✓
pages-turbo...prod.js gzip 22.1 kB 22.1 kB ✓
pages.runtim...dev.js gzip 22.8 kB 22.8 kB ✓
pages.runtim..prod.js gzip 22.1 kB 22.1 kB ✓
server.runti..prod.js gzip 50.2 kB 50.2 kB ✓
Overall change 927 kB 927 kB ✓
build cache
vercel/next.js canary vercel/next.js kdy1/pack-2538 Change
0.pack gzip 1.49 MB 1.49 MB N/A
index.pack gzip 104 kB 104 kB N/A
Overall change 0 B 0 B ✓
Commit: 5f60a7c

@kdy1 kdy1 marked this pull request as ready for review February 20, 2024 02:35
@sokra sokra merged commit 8d6c1a6 into canary Feb 22, 2024
70 checks passed
@sokra sokra deleted the kdy1/pack-2538 branch February 22, 2024 07:51
kdy1 added a commit to vercel/turborepo that referenced this pull request Feb 22, 2024
@kdy1 @sokra
fix(turbopack): Use different title for non-parsing issues (#7421)
8b338f7 
### Description

We shared a `Handler` instance, and thus, we used `Parsing ecmascript source code failed` even for non-parsing issues.


### Testing Instructions

next.js counterpart: vercel/next.js#62259

Closes PACK-2538

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
@github-actions github-actions bot added the locked label Mar 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra sokra approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees

@kdy1 kdy1

Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdy1 @ijjk @sokra